Edinburgh is ok if you can put up with the banal patriotic schmaltz of all things Scotch but really it's like going back to the 1700's. Boring as ****. You'd be better taking a trip out to Livingston which is far more modern and doesn't rely on the chessieness that Edinburgh depicts and attracts. There is far more to Scotchland than it's second capital.
I like Edinburgh, but if you're going to take kids it really depends on how old they are. I got taken when I was about 16 and I enjoyed it, but I definitely wouldn't take younger kids.
Just ignore all the negative stuff above. It's mostly from Glaswegians and ex-pat weegies. Edinburgh is a great city with plenty to do.
I really like Edinburgh ST, but more for a booze up than somewhere to keep kids occupied. And I mean that as in giving them something exciting to do, not in your "Joseph Fritzl" way of keeping kids "occupied"...
This is Edinburgh's top tourist attraction: please log in to view this image A bit of road you're allowed to spit on.